-
Notifications
You must be signed in to change notification settings - Fork 58
task(RHOAIENG-35928): Add HTTPRoute detection #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task(RHOAIENG-35928): Add HTTPRoute detection #926
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
+ Coverage 94.24% 94.34% +0.09%
==========================================
Files 24 24
Lines 2033 2068 +35
==========================================
+ Hits 1916 1951 +35
Misses 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laurafitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question inline.
378708f to
f5e154a
Compare
f5e154a to
cf8a6fe
Compare
|
/hold |
|
Verified backwards compatibility on Openshift Route. |
cf8a6fe to
dd84deb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chipspeak, laurafitzgerald The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
538e780
into
project-codeflare:main
Issue link
RHOAIENG-35928
What changes have been made
Implemented HTTPRoute-based dashboard URLs for SDK v0.31.1 and below with automatic fallback to OpenShift Routes for backward compatibility.
Verification steps
The below needs to be tested on an oidc cluster / a cluster with HTTP Routes and Gateway API enabled (annoy Cathal for this)
Checks